Repository navigation
[No QA] Wrap personal details list access behind hooks, store and update builder - #101075
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9d3b5c3c2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
This PR adds a new |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00c29e1b5d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
mountiny
left a comment
mountiny
left a comment
There was a problem hiding this comment.
Approving the connectWithoutView usecase, this is refactoring mainly
|
This PR adds a new |
…-calls # Conflicts: # config/eslint/eslint.seatbelt.tsv
|
thanks for your comments @nkdengineer |
tgolen
left a comment
tgolen
left a comment
There was a problem hiding this comment.
I approve the connectWithoutView() reference
|
This PR adds a new |
mountiny
left a comment
mountiny
left a comment
There was a problem hiding this comment.
Thanks for addressing those
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.81-0 🚀
|
|
No help site changes are required for this PR, so I did not create a docs PR. This is an internal refactor with no user-facing surface. Nothing in Why I concluded thatEvery changed file is developer tooling or internal plumbing:
There are no changes to There is no help site PR to link here, so nothing needs to be marked ready. If you disagree and want an article updated, tell me which one and I'll open the draft PR. @TMisiukiewicz, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
Explanation of Change
ONYXKEYS.PERSONAL_DETAILS_LISTis referenced directly in about 200 files. Reshaping personal details into an Onyx collection today would mean editing all of them; after this PR it means editing three places.Those three places are
@hooks/usePersonalDetails(usePersonalDetail,usePersonalDetailsByIDs,useAllPersonalDetails) for React,@libs/PersonalDetailsStorefor callers outside React, andbuildPersonalDetailsUpdateinPersonalDetailsUtilsfor writes. A new ESLint rule,rulesdir/no-direct-personal-details-list, reports any new direct reference to the key, and its unit tests cover the read, write, mask and type positions. The 270 existing references across 197 files go into the eslint seatbelt baseline and move onto the wrappers in follow-up PRs.I also moved the login-to-personal-details cache out of
PersonalDetailsUtilsinto the store, so a singleOnyx.connectWithoutViewsubscription builds it. Nothing calls the wrappers yet, soknip.jsonsuppresses them throughignoreIssuesuntil the first migration PR lands. Behavior is unchanged.Fixed Issues
$ #101087
PROPOSAL:
Tests
No tests needed, code is unused now
Offline tests
QA Steps
No QA — this is a refactor with no user-facing change.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari